Add ClassMetadataFactoryInterface to allow switching implementation #11497
Conversation
| @@ -154,6 +154,7 @@ | |||
|
|
|||
| <rule ref="SlevomatCodingStandard.Classes.SuperfluousInterfaceNaming"> | |||
| <exclude-pattern>src/EntityManagerInterface.php</exclude-pattern> | |||
| <exclude-pattern>src/Mapping/ClassMetadataFactoryInterface.php</exclude-pattern> | |||
There was a problem hiding this comment.
Why was this excluded from phpcs checks? It's going to be a new interface that you can name without the superflous naming.
There was a problem hiding this comment.
Doctrine\ORM\Mapping\ClassMetadataFactory is already used (is the name of the current implementation).
Do you have a better proposal for the name of this interface?
| $reflectionClass = new ReflectionClass($cmfName); | ||
| if (! $reflectionClass->implementsInterface(ClassMetadataFactoryInterface::class)) { | ||
| throw InvalidClassMetadataFactory::create($cmfName); | ||
| } |
There was a problem hiding this comment.
This would introduce an exception when there was not one before.
There was a problem hiding this comment.
Prior to this PR a call with a class different from Doctrine\ORM\Mapping\ClassMetadataFactory would cause a TypeError. So yes, it would not throw an exception here, but in a different (and completely unrelated) point of the code, which can be harder to debug.
New Feature
Summary
Fixes #11496
This PR introduces a new
ClassMetadataFactoryInterfaceinterface and changes the type-hints to allow switching implementation of the factory in configuration.