-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix matching lazy collections with enums criteria #11516
base: 3.2.x
Are you sure you want to change the base?
Conversation
d38e933
to
f9dbfdf
Compare
Please find a meaningful title for your PR. We use the titles in our automatically composed change log. |
Hello @derrabus |
Up @derrabus . This PR is still stuck because of your ghost request change 😢 |
Hi, I've got these issues from Psalm:
And I don't understand what it means... I don't know how to fix those "issues". Thanks for your help. |
Your changes seem to have removed code with psalm issues that is still ignored in the psalm baseline and don't need to be anymore. If you find the affected lines in the XML for |
5e312cc
to
adf4a53
Compare
Hi @derrabus I don't know why, but the merging is blocked because of a change you requested on one of the commits of this branch. Thanks a lot. |
Fix issue #11481
I identified some duplicated code between the
BasicEntityPersister
and theManyToManyPersister
, like the methodexpandCriteriaParameters
.Because I don't want to create side effects, I just factorized two methods :
getValues
andgetIndividualValue
into a trait.Thanks for your review !