Re: Add support for using nested DTOs

[eltharin]

Fork for errors correction of #11238

[norkunas]

Your commit lost all the other authors credits 🙄

[eltharin]

Take my changes and make it to yours, you don't touch your PR since 5 month but it's a super idea.

And if you can explain me how I had to do, i'm not very comfortable with PR workflow.

[norkunas]

It's not my commits also, I've just cherry-picked to adapt for current codebase.

you don't touch your PR since 5 month

Because I've waited to get some directions what I should do? As I see you just pushed that error to the baseline

[norkunas]

And if you can explain me how I had to do, i'm not very comfortable with PR workflow.

git cherry-pick commit-hash it's a one line and then conflicts resolving if needed :)

[eltharin]

@norkunas you want to make corrections to your repo or I continue here ?

[norkunas]

No prob if you'll continue

[greg0ire]

Please improve your commit message according to the contributing guide.

[eltharin]

and if you have 10 minutes, don't hesitate to explain to me what could have been done better by email.
For doing better last time.

[greg0ire]

I wrote the contributing guide (at least the part about the commit messages). Is there a part that is unclear? Also, I'd rather talk on doctrine.slack.com if you don't mind.

[eltharin]

sorry I read a little so fast, I think it was "just" beacause my commit was only "corrections" without any more.

[greg0ire]

I don't think people reading the history once this is merged need to know there was a need to update the baseline. Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble.

How to do that?

1. git rebase -i origin/3.2.x, assuming origin is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, run git remote -vvv, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.
2. A window will show up with many lines, replace pick with fixup on every line but the first one
3. Close your editor, git should do its magic, and you should end up with one commit
4. Use git push --force to overwrite what you already push. Don't forget the --force option otherwise git will try to merge both things together.

[greg0ire]

The docs need to be adjusted, as they say "Note that you can only pass scalar expressions to the constructor." DTOs are not scalar expressions.

[greg0ire]

Thanks @eltharin !

[greg0ire]

Argh! Wrong target branch 😓
This should have targeted 3.3.x

[derrabus]

Shall I do a hard reset or do you prefer a revert? 🫣

[greg0ire]

Did the hard reset already

[greg0ire]

@eltharin please recreate this PR, but this time, target 3.3.x please. More help on this at #11208

[eltharin]

ok