fix: Quote custom types correctly in SQLFilter #11546
Open
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the connection to quote the parameters correctly according to the type definition.
My scenario:
doctrine/dbal:3.8.2
doctrine/orm:3.2.1
, currently updating fromdoctrine/orm:2.19.5
UlidType
from the doctrine bridge (usingsymfony/ulid
underneath) as primary key to theOrganization
entityMy problem:
I'm using a SQLFilter to permanently set the ulid of the organization permanently for users. After updating
doctrine/orm
, I got an exception that the format of the query parameter wouldn't conform to the expectation of the database.My solution
On investigation, I found that the SQLFilter doesn't use the column type to quote the value correctly. This change is supposed to ensure that the correct quoting is done