Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQL custom functions: document TypedExpression #11550

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

janedbal
Copy link
Contributor

Partially related to #11537

docs/en/cookbook/dql-user-defined-functions.rst Outdated Show resolved Hide resolved
docs/en/cookbook/dql-user-defined-functions.rst Outdated Show resolved Hide resolved
docs/en/cookbook/dql-user-defined-functions.rst Outdated Show resolved Hide resolved
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Please squash your 4 commits into 1.

@janedbal
Copy link
Contributor Author

janedbal commented Aug 6, 2024

No problem. Just out of curiosity, why do you force contributors to squash it manually when you can do it with a single button?

image

Partially related to doctrine#11537

Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com>
@greg0ire
Copy link
Member

greg0ire commented Aug 6, 2024

For me, there are at least 2 reasons:

  • Pressing that button forces us to come up with a commit message summarizing all the commits. Crafting that commit message should IMO be your job, since it's your changes.
  • The commit hash stays the same before and after merging, when no squashing is involved. That can be handy when trying to figure out what branch contains a particular commit or whatnot.

@greg0ire greg0ire added this to the 3.2.2 milestone Aug 9, 2024
@greg0ire greg0ire merged commit 205b2f5 into doctrine:3.2.x Aug 9, 2024
1 check passed
@greg0ire
Copy link
Member

greg0ire commented Aug 9, 2024

Thanks @janedbal !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants