Catch Throwable instead of just catching Exception
#5796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is something blocking this, or you guys just haven't had time to look at this? Also, the same problem is in dbal (I've created a PR for it doctrine/dbal#2390 ) |
|
@fprochazka we're simply stuck outside the githubs. |
| @@ -749,7 +751,9 @@ public function dropSchema(array $classes) | |||
| foreach ($dropSchemaSql as $sql) { | |||
| try { | |||
| $conn->executeQuery($sql); | |||
| } catch (\Exception $e) { | |||
| } catch (\Throwable $e) { | |||
There was a problem hiding this comment.
Now that i think about it, this one probably shouldn't caught.
There was a problem hiding this comment.
Godd catch. Indeed, this should halt execution
There was a problem hiding this comment.
This is another issue then :)
|
What's the deal with this one? Shouldn't this get merged? |
|
@rreynier see comments above? |
|
@Ocramius what do you mean by being stuck outside of GitHub? |
|
Paid work, but also missing clean-up work to be done here. I can work on it
today tho.
…On 1 Sep 2017 08:47, "Roeland Reyniers" ***@***.***> wrote:
@Ocramius <https://github.com/ocramius> what do you mean by being stuck
outside of GitHub?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5796 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakLWOe-Zvj1mHbGmCrRv9K4EFxVb8ks5sd6h0gaJpZM4INGvA>
.
|
Ocramius
added a commit
that referenced
this pull request
Sep 2, 2017
Ocramius
added a commit
that referenced
this pull request
Sep 2, 2017
Ocramius
changed the title
Throwable instead of just catching Exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several code blocks have a catch-all
catch (\Exception) { ... }. This is OK in PHP 5, but not sufficient in PHP 7, as the new base interface isThrowable, and catchingExceptiondoes not catchErrorinstances.This PR catches
Throwableby default, then catchesExceptionfor PHP 5. The fact thatThrowableis not defined in PHP 5 is not a problem in a catch block.This leads to a bit of code duplication, but there's not much we can do to avoid this I'm afraid.