Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapted some mocks to php 7.2 #7087

Closed
wants to merge 1 commit into from
Closed

adapted some mocks to php 7.2 #7087

wants to merge 1 commit into from

Conversation

fullbl
Copy link
Contributor

@fullbl fullbl commented Feb 22, 2018

Some tests were failing on php 7.2, due to incompatible declarations with DBAL Statement class

@Majkl578
Copy link
Contributor

This is not correct, these changes were introduced just recently in #7076 and #7065, because DBAL develop (3.0-dev) changed signatures.

@fullbl
Copy link
Contributor Author

fullbl commented Feb 22, 2018

Whoops, I supposed it was the opposite!

@fullbl fullbl closed this Feb 22, 2018
@Majkl578
Copy link
Contributor

No problem. ORM dev-master already depends on DBAL dev-develop so master is up to date. Please see doctrine/dbal#2958 for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fullbl @Majkl578