Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that cache is created when using single scalar hydrator #7560

Open
wants to merge 10 commits into
base: 2.10.x
Choose a base branch
from

Conversation

goetas
Copy link
Member

@goetas goetas commented Jan 8, 2019

Checks that doctrine/dbal#3381 works with the ORM.

This will require most likley to put doctrine/dbal:^2.9.4 (2.9.4 is not yet released)

So not sure if it makes sense (but since orm 2.7 requires at least php 7.2, do not see anything wrong with it)

@goetas
Copy link
Member Author

goetas commented Jan 8, 2019

hmm, something is wrong with my test, https://travis-ci.org/doctrine/orm/jobs/476824447 should be failing

ah, no was introduced in doctrine/dbal#3331 and fixed with doctrine/dbal#3381

so only v2.9.2 v2.9.1 v2.9.0 are affected

@goetas
Copy link
Member Author

goetas commented Jan 8, 2019

BTW doctrine/dbal#3331 is relatively bad as the cache does not keep track of the fetch mode. I think the best thing to do is to revert doctrine/dbal#3331

@goetas
Copy link
Member Author

goetas commented Apr 24, 2019

Ping... nobody here?

@greg0ire
Copy link
Member

This will require most likley to put doctrine/dbal:^2.9.4 (2.9.4 is not yet released) So not sure if it makes sense (but since orm 2.7 requires at least php 7.2, do not see anything wrong with it)

IMO it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants