Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8 Support #8303

Merged
merged 23 commits into from
Nov 15, 2020
Merged

PHP8 Support #8303

merged 23 commits into from
Nov 15, 2020

Conversation

beberlei
Copy link
Member

@beberlei beberlei commented Oct 11, 2020 •
edited
Loading

Attributes

Support for an Attribute Metadata Driver will be added seperately in #8266

As discussed in #8266 we need a few small changes on doctrine/annotations. These are addressed in doctrine/annotations#369 and we are next going for for annotations 1.11 release to include this.

derrabus
derrabus reviewed Oct 19, 2020
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@zingimmick zingimmick mentioned this pull request Oct 23, 2020
Merged
9 tasks
@kbond kbond mentioned this pull request Oct 30, 2020
Merged
3 tasks
@nanasess nanasess mentioned this pull request Nov 2, 2020
Closed
@beberlei beberlei mentioned this pull request Nov 7, 2020
Merged
beberlei added 13 commits November 7, 2020 20:35
@beberlei @greg0ire
Update doctrine/dbal to 2.12 for PHP 8 support.
477c27f
@beberlei @greg0ire
Change Query\Parser::match to Query\Parser::matchToken including DQL …
e2e85d1 
…functions.
@beberlei @greg0ire
Fix phpunit constraint to 9.4, adjust @group usage to workaround PHPU…
fe4e9ca 
…nit bug.
@beberlei @greg0ire
Fix PHPUnit API related changes.
8f69613
@beberlei @greg0ire
Add PHP 8 support for EntityGenerator namespace detection.
d0c3497
@beberlei @greg0ire
Use new assertEqualsWithDetla for QueryDqlFunctionTest with date comp…
b6d7797 
…arisons
@beberlei @greg0ire
Replace ReflectionParameter::getClass usage with non-deprecated ::get…
6604a32 
…Type instead.
@beberlei @greg0ire
Revert "Change Query\Parser::match to Query\Parser::matchToken includ…
080d72c 
…ing DQL functions."

This reverts commit 2790704.
@beberlei @greg0ire
More matchToken => match reverts
68b23b3
@beberlei @greg0ire
Housekeeping: phpcs
c226a44
@beberlei @greg0ire
Housekeeping: phpcs
c041104
@beberlei @greg0ire
Housekeeping: phpcs
b9af10e
@beberlei @greg0ire
Housekeeping: phpcs
fe6eeb2
@kdambekalns kdambekalns mentioned this pull request Nov 10, 2020
Closed
This was referenced Nov 10, 2020
Closed
Merged
@greg0ire greg0ire mentioned this pull request Nov 12, 2020
Closed
@beberlei beberlei marked this pull request as ready for review November 15, 2020 10:15
greg0ire
greg0ire reviewed Nov 15, 2020
View reviewed changes
composer.json Outdated Show resolved Hide resolved
greg0ire
greg0ire approved these changes Nov 15, 2020
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@beberlei beberlei merged commit 3d46e07 into doctrine:2.8.x Nov 15, 2020
@beberlei beberlei deleted the Php8Support branch November 15, 2020 12:24
@ausi ausi mentioned this pull request Nov 20, 2020
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus left review comments

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beberlei @greg0ire @derrabus