Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused exceptions #8851

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Remove unused exceptions #8851

merged 1 commit into from
Jul 21, 2021

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Jul 20, 2021 •
edited
Loading

After discussing this with @beberlei , we picked 2.10.x as a target branch since these methods are very unlikely to be used outside the project.

Backports #7008

SenseException
SenseException approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instances of ORM exceptions shouldn't be created outside of ORM.

@greg0ire greg0ire added this to the 2.10.0 milestone Jul 21, 2021
@greg0ire greg0ire merged commit 3e18990 into doctrine:2.10.x Jul 21, 2021
@greg0ire greg0ire deleted the backport-7008 branch July 21, 2021 05:45
@github-actions github-actions bot mentioned this pull request Oct 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
Backporting BC Break
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@greg0ire @SenseException