Change $this->assert* to self::assert* in unit tests #8862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Aug 2, 2021
SenseException
approved these changes
Aug 2, 2021
|
Thanks @carnage ! |
|
Will try and find time at the weekend to have another go at backporting the test improvements PR now this should solve a lot of the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #6854 this PR updates all the unit tests to use self::assert* instead of $this->assert*
This was already done in the v3 develop branch and it'll smooth merging one of the remaining backports.
It was generated using this command:
php ./php-cs-fixer-v2.phar fix ./tests/ --rules='{"php_unit_test_case_static_method_calls":{"call_type": "self"}}' --allow-risky=yesI would suggest if there is a delay in merging and conflicts come up, that someone just reruns that on a new branch taken from 2.10.x instead of trying to fix the conflicts.