Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI SA failures #8872

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Fix CI SA failures #8872

merged 1 commit into from
Aug 2, 2021

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Aug 1, 2021

No description provided.

@simPod simPod mentioned this pull request Aug 1, 2021
Merged
@greg0ire
Copy link
Member

greg0ire commented Aug 2, 2021

@simPod this looks like a bugfix. Shouldn't it target 2.9.x?

@simPod simPod changed the base branch from 2.10.x to 2.9.x August 2, 2021 16:31
@simPod
Copy link
Contributor Author

simPod commented Aug 2, 2021

Was not aware those issues disappeared on 2.9.x as well. Retargeted.

@greg0ire greg0ire added the Bug label Aug 2, 2021
This was referenced Aug 2, 2021
Closed
Merged
SenseException
SenseException approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any tests for this class?

@greg0ire
Copy link
Member

greg0ire commented Aug 2, 2021

The test suite passes even after throwing right at the beginning of execute, so I don't think we do.

@greg0ire greg0ire merged commit 6fc0176 into doctrine:2.9.x Aug 2, 2021
@greg0ire greg0ire added this to the 2.9.4 milestone Aug 2, 2021
@greg0ire
Copy link
Member

greg0ire commented Aug 2, 2021

Thanks @simPod !

@simPod simPod deleted the fix-build branch August 3, 2021 06:29
@github-actions github-actions bot mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@greg0ire greg0ire greg0ire approved these changes

@beberlei beberlei Awaiting requested review from beberlei

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.9.4
Development

Successfully merging this pull request may close these issues.
3 participants
@simPod @greg0ire @SenseException