Remove calls to deprecated Connection methods #8935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/deprecated-calls
branch
2 times, most recently
from
43b4713 to
97a4bf0
Compare
greg0ire
previously approved these changes
Aug 22, 2021
derrabus
force-pushed
the
improvement/deprecated-calls
branch
from
97a4bf0 to
7da9a31
Compare
greg0ire
previously approved these changes
Aug 22, 2021
derrabus
force-pushed
the
improvement/deprecated-calls
branch
from
7da9a31 to
7383e35
Compare
derrabus
force-pushed
the
improvement/deprecated-calls
branch
from
7383e35 to
730143e
Compare
greg0ire
approved these changes
Aug 23, 2021
|
Thanks @derrabus ! |
|
I was in the middle of a review and wondered about the scope of the PR. I guess I don't have to think about that anymore 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes more calls to deprecated methods of the
Connectionclass, mainlyfetchColumn(),exec()andexecuteUpdate().