Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a setup helper for attribute metadata config #9133

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Adding a setup helper for attribute metadata config #9133

merged 1 commit into from
Oct 28, 2021

Conversation

judahnator
Copy link
Contributor

I noticed there was a \Doctrine\ORM\Tools\Setup::createAnnotationMetadataConfiguration method, but a method for attributes was missing. This PR adds a similar \Doctrine\ORM\Tools\Setup::createAttributeMetadataConfiguration method as well.

First time PR to Doctrine so go easy :)

@greg0ire
Copy link
Member

greg0ire commented Oct 19, 2021

This is a new feature and as such, should target 2.11.x. You can retarget with the Edit button.
Note that I'm not 100% sure about this, since it could also be seen as a bugfix for something we forgot. WDYT @SenseException @derrabus

@judahnator judahnator changed the base branch from 2.10.x to 2.11.x October 19, 2021 20:34
@SenseException
Copy link
Member

Technically 2.11, but Setup just exists to make things easier for users, so I guess 2.10 would be okay too.

@judahnator
Copy link
Contributor Author

Where are we at with this one? Any last changes needing made?

@derrabus
Copy link
Member

Any last changes needing made?

Yes, the CI needs to be green.

@derrabus
Copy link
Member

Other than that, are we able to provide a test for your change?

@judahnator
Copy link
Contributor Author

I wrote a test and the checks have passed!

@greg0ire
Copy link
Member

There are 7 commits, please get rid of the first one, and squash the others together

How to do that?

  1. git rebase -i origin/2,11,x, assuming origin is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, run git remote -vvv, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.
  2. A window will show up with many lines, replace pick with drop on the first line, and then pick with fixup on every line but the second one
  3. Close your editor, git should do its magic, and you should end up with one commit
  4. Use git push --force to overwrite what you already push. Don't forget the --force option otherwise git will try to merge both things together.

@judahnator
Copy link
Contributor Author

Neat! I didn't know about those neat git tricks. Hopefully, I got everything right!

@greg0ire greg0ire merged commit 2074fc3 into doctrine:2.11.x Oct 28, 2021
@greg0ire greg0ire added this to the 2.11.0 milestone Oct 28, 2021
@greg0ire
Copy link
Member

Congrats @judahnator !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants