-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a setup helper for attribute metadata config #9133
Conversation
This is a new feature and as such, should target 2.11.x. You can retarget with the Edit button. |
Technically 2.11, but |
Where are we at with this one? Any last changes needing made? |
Yes, the CI needs to be green. |
Other than that, are we able to provide a test for your change? |
I wrote a test and the checks have passed! |
There are 7 commits, please get rid of the first one, and squash the others together How to do that?
|
Neat! I didn't know about those neat git tricks. Hopefully, I got everything right! |
Congrats @judahnator ! |
I noticed there was a
\Doctrine\ORM\Tools\Setup::createAnnotationMetadataConfiguration
method, but a method for attributes was missing. This PR adds a similar\Doctrine\ORM\Tools\Setup::createAttributeMetadataConfiguration
method as well.First time PR to Doctrine so go easy :)