Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing list "Lifecycle Events" #9243

Merged
merged 15 commits into from
Dec 28, 2021
Merged

Removing list "Lifecycle Events" #9243

merged 15 commits into from
Dec 28, 2021

Conversation

ThomasLandauer
Copy link
Contributor

@ThomasLandauer ThomasLandauer commented Dec 12, 2021 •
edited
Loading

As announced in #9184 (comment)

I'm committing the events one by one, to make it easier to follow.

Notes:

  • postUpdate, postRemove, postPersist aren't similar enough to have them in one section, so it might be better to separate them.
  • This warning I don't understand. I moved it to postRemove. Should it be repeated on all "events triggered after an entity removal" (which ones?):

    The postRemove event or any events triggered after an entity removal
    can receive an uninitializable proxy in case you have configured an entity to
    cascade remove relations. In this case, you should load yourself the proxy in
    the associated pre* event.

@SenseException
Copy link
Member

Great work. Please change your commit messages into meaningful ones as described in https://www.doctrine-project.org/contribute/index.html#crafting-meaningful-commit-messages.

@derrabus
Copy link
Member

We can (and should) squash the commits on merge, @SenseException.

@ThomasLandauer
Copy link
Contributor Author

If you squash them, should I still change something?

@derrabus derrabus added this to the 2.10.5 milestone Dec 28, 2021
derrabus
derrabus approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we're good. Thank you.

@derrabus derrabus merged commit e8275f6 into doctrine:2.10.x Dec 28, 2021
@ThomasLandauer ThomasLandauer deleted the patch-1 branch December 28, 2021 13:30
derrabus added a commit to derrabus/orm that referenced this pull request Dec 31, 2021
@derrabus
Merge branch '2.10.x' into 2.11.x
37ce986 
* 2.10.x:
  Bump PHPStan & Psalm (doctrine#9303)
  Removing list "Lifecycle Events" (doctrine#9243)
  Drop unneeded backslashes
  Fix Hidden fields triggering error when using getSingleScalarResult() (doctrine#8340)
  Findby joined lookup (doctrine#8285)
derrabus added a commit to derrabus/orm that referenced this pull request Dec 31, 2021
@derrabus
Merge branch '2.10.x' into 2.11.x
133cc95 
* 2.10.x:
  Bump PHPStan & Psalm (doctrine#9303)
  Removing list "Lifecycle Events" (doctrine#9243)
  Drop unneeded backslashes
  Fix Hidden fields triggering error when using getSingleScalarResult() (doctrine#8340)
  Findby joined lookup (doctrine#8285)
derrabus added a commit to derrabus/orm that referenced this pull request Dec 31, 2021
@derrabus
Merge branch '2.11.x' into 3.0.x
4b062a4 
* 2.11.x:
  Bump PHPStan & Psalm (doctrine#9303)
  Removing list "Lifecycle Events" (doctrine#9243)
  Drop unneeded backslashes
  Fix Hidden fields triggering error when using getSingleScalarResult() (doctrine#8340)
  Findby joined lookup (doctrine#8285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@SenseException SenseException Awaiting requested review from SenseException

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
2.10.5
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasLandauer @SenseException @derrabus