Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run PHP CodeSniffer on PHP 8.1 #9317

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Jan 1, 2022

Same as #9310, but for CodeSniffer. Running on PHP 7.4, CodeSniffer won't understand newer Syntax elements like readonly which will cause trouble (see #9316). Since we declare the PHP language level in CodeSniffer's configuration, running the tool on PHP 8.1 should be fine.

@derrabus derrabus added the CI label Jan 1, 2022
@derrabus derrabus requested review from beberlei and greg0ire January 1, 2022 23:07
@derrabus derrabus force-pushed the improvement/phpcs-on-8.1 branch from f04f9e7 to f2495c3 Compare January 1, 2022 23:09
@derrabus derrabus added this to the 2.10.5 milestone Jan 1, 2022
@derrabus derrabus enabled auto-merge (squash) January 2, 2022 13:15
@derrabus derrabus disabled auto-merge January 2, 2022 13:15
@derrabus derrabus merged commit 8b5ee54 into doctrine:2.10.x Jan 2, 2022
@derrabus derrabus deleted the improvement/phpcs-on-8.1 branch January 2, 2022 13:15
derrabus added a commit to derrabus/orm that referenced this pull request Jan 2, 2022
* 2.10.x:
  Run PHP CodeSniffer on PHP 8.1 (doctrine#9317)
  Psalm 4.17.0 (doctrine#9315)
derrabus added a commit to derrabus/orm that referenced this pull request Jan 2, 2022
* 2.11.x:
  Run PHP CodeSniffer on PHP 8.1 (doctrine#9317)
  Psalm 4.17.0 (doctrine#9315)
  Run static analysis on PHP 8.1 (doctrine#9310)
derrabus added a commit to derrabus/orm that referenced this pull request Jan 2, 2022
* 2.11.x:
  Run static analysis with language level PHP 8.1 (doctrine#9314)
  Document LockMode enums (doctrine#9319)
  Document PHPUnit mocks with intersection types (doctrine#9318)
  Run PHP CodeSniffer on PHP 8.1 (doctrine#9317)
  Psalm 4.17.0 (doctrine#9315)
  Run static analysis on PHP 8.1 (doctrine#9310)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant