PHPStan 1.3.3, Psalm 4.18.1 #9341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Jan 9, 2022
psalm-baseline.xml
Outdated
| <InvalidScalarArgument occurrences="2"> | ||
| <code>$optionalSecondSimpleArithmeticExpression</code> | ||
| <code>$sqlWalker->walkSimpleArithmeticExpression($this->firstSimpleArithmeticExpression)</code> | ||
| </InvalidScalarArgument> |
There was a problem hiding this comment.
Some of these would need to be "moved" to a baseline specific to 2.13
There was a problem hiding this comment.
I could also move them to psalm.xml.dist and add a comment that this applies to DBAL 2 only. That should stabilize the baseline as well.
|
Sorry, I meant to close my own PR… |
greg0ire
force-pushed
the
bump/phpstan-psalm
branch
from
86d218f to
f3630ea
Compare
greg0ire
approved these changes
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.