Add Failing Test Case for Invalid Bidirectional Association Mapping with Mapped Superclass in Class Hierarchy

[bobdercole]

See #9516.

[mpdude]

Is this related to #8415 somehow?

[bobdercole]

Yes! The inheritance hierarchy you have defined is the same as mine.

/**
 * @Entity
 */
class GH9516Passenger
{
    /**
     * @var int $id
     * @Id
     * @Column(type="integer")
     */
    private $id;

    /**
     * @var GH9516Vehicle $vehicle
     * @ManyToOne(targetEntity="GH9516Vehicle", inversedBy="passengers")
     */
    private $vehicle;
}

/**
 * @Entity
 */
abstract class GH9516Vehicle
{
    /**
     * @var int $id
     * @Id
     * @Column(type="integer")
     */
    private $id;

    /**
     * @var GH9516Passenger[] $passengers
     * @OneToMany(targetEntity="GH9516Passenger", mappedBy="vehicle")
     */
    private $passengers;
}

/**
 * @MappedSuperclass
 */
abstract class GH9516Car extends GH9516Vehicle
{
}

/**
 * @Entity
 */
class GH9516SportsCar extends GH9516Car
{
}

The big difference is the association. Mine defines a one-to-many bidirectional relationship on the base class. My issue occurs when validating the mapping; an exception is thrown.

Your fix almost solves this issue. My test cases passes if I add your extra condition to the illegal association on mapped superclass check, like so:

if ($parentClass->isMappedSuperclass) {
    if ($mapping['type'] & ClassMetadata::TO_MANY && ! $mapping['isOwningSide'] && ! isset($mapping['inherited'])) {
        throw MappingException::illegalToManyAssociationOnMappedSuperclass($parentClass->name, $field);
    }

    if (! isset($mapping['inherited'])) {
        $mapping['sourceEntity'] = $subClass->name;
    }
}