Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate omitting second argument to joinColumnName() #9747

Merged
merged 2 commits into from
May 9, 2022

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented May 9, 2022

I don't think there is a sensible way to actually enforce that deprecation.

@greg0ire greg0ire force-pushed the precise-phpdoc-naming-strategy branch from 4a74ea9 to 20124d5 Compare May 9, 2022 21:05
@greg0ire greg0ire force-pushed the precise-phpdoc-naming-strategy branch from 20124d5 to 37e664d Compare May 9, 2022 21:11
@derrabus derrabus added this to the 2.13.0 milestone May 9, 2022
@derrabus derrabus merged commit 6757bdf into doctrine:2.13.x May 9, 2022
@greg0ire greg0ire deleted the precise-phpdoc-naming-strategy branch May 10, 2022 05:44
@stof
Copy link
Member

stof commented May 10, 2022

if you add the @param in the interface, the DebugClassLoader of Symfony will be able to trigger a deprecation at autoloading time for projects using it.

@greg0ire
Copy link
Member Author

OK, I'll give that another try! IIRC it will require ignoring some errors from SA tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants