Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve orphan removal documentation - recommend using cascade=persist #9848

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Improve orphan removal documentation - recommend using cascade=persist #9848

merged 3 commits into from
Aug 9, 2022

Conversation

olsavmic
Copy link
Contributor

Resolves #9847

@olsavmic olsavmic force-pushed the mo-orphan-removal-doc-improve branch 2 times, most recently from 3d9d168 to 6de9d59 Compare June 15, 2022 14:33
@olsavmic olsavmic changed the base branch from 2.12.x to 2.11.x June 15, 2022 14:34
@olsavmic olsavmic requested a review from SenseException June 17, 2022 12:03
@SenseException
Copy link
Member

I just saw that you're targeting 2.11 instead of 2.12. Please change and rebase to 2.12.x

@olsavmic olsavmic force-pushed the mo-orphan-removal-doc-improve branch from 869de8b to eb1ef01 Compare June 25, 2022 12:09
@olsavmic olsavmic changed the base branch from 2.11.x to 2.12.x June 25, 2022 12:09
@olsavmic
Copy link
Contributor Author

olsavmic commented Jun 25, 2022 •
edited
Loading

Rebased onto 2.12.x, thanks!

SenseException
SenseException requested changes Jun 27, 2022
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can keep the original orphanRemoval example above your newly added note. It's still a valid example. You can create your own shorter code example below your note to separate both cases.

docs/en/reference/working-with-associations.rst Outdated Show resolved Hide resolved
@olsavmic @SenseException
Update docs/en/reference/working-with-associations.rst
a5cff8a 
Co-authored-by: Claudio Zizza <859964+SenseException@users.noreply.github.com>
@olsavmic olsavmic requested a review from SenseException August 8, 2022 16:27
@derrabus derrabus changed the base branch from 2.12.x to 2.13.x August 8, 2022 18:11
@derrabus derrabus added this to the 2.13.2 milestone Aug 8, 2022
@SenseException SenseException merged commit 18be6d2 into doctrine:2.13.x Aug 9, 2022
@SenseException
Copy link
Member

Thank you @olsavmic 🚀

derrabus added a commit to derrabus/orm that referenced this pull request Aug 26, 2022
@derrabus
Merge branch '2.14.x' into 3.0.x
28b5dfd 
* 2.14.x:
  Bump coding standard to 9.0.2
  Fix tests for doctrine/common 3.4
  Fix static analysis errors for Collections 1.7
  Fix type in docs (doctrine#9994)
  Improve orphan removal documentation - recommend using cascade=persist  (doctrine#9848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
2.13.2
Development

Successfully merging this pull request may close these issues.

OrphanRemoval does not work with ArrayCollection and manual persist which is not mentioned in the docs
3 participants
@olsavmic @SenseException @derrabus