Make EntityManager @final and its constructor public

[nicolas-grekas]

Fix #9896

[derrabus]

Thanks. Can you have a look at the failing tests?

[nicolas-grekas]

Likely not before a week but otherwise yes!
What about removing the last argument of the constructor btw?

[derrabus]

What about removing the last argument of the constructor btw?

That's probably a good idea.

[nicolas-grekas]

Tests updated, PR should be ready.

[greg0ire]

There was a cancelled job, I'm running it again, hopefully it will pass. I don't know why it was cancelled.

[greg0ire]

The performance of that job is suspiciously bad: https://github.com/doctrine/orm/runs/7559763390?check_suite_focus=true, even when compared with this other random PR: https://github.com/doctrine/orm/runs/7558748372?check_suite_focus=true
Let me re-run that last one.

[greg0ire]

It's slower than usual (1m13), but not as slow, let me restart the first one then.

[greg0ire]

53s 🙂

[greg0ire]

Thanks @nicolas-grekas !

[nicolas-grekas]

Thanks for merging \o/