Skip to content
This repository has been archived by the owner on Jan 24, 2025. It is now read-only.

Pass the entry property down to the wrapper #1181

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Pass the entry property down to the wrapper #1181

merged 2 commits into from
Oct 17, 2019

Conversation

pepicrft
Copy link
Contributor

Resolves #1177

Description

Passes the entry property down to the Wrapper component, which will allow developers to use it for things like setting meta headers in the header.

@pepicrft
Copy link
Contributor Author

@rakannimer let me know if there's anything else that I should do as part of this PR. I tried to run the tests locally but I got the following error:

docz-core:   ● Test suite failed to run
docz-core:     Cannot find module 'docz-core' from '/Users/pedropinera/src/github.com/doczjs/docz/core/docz-core/src/config'
docz-core:     However, Jest was able to find:
docz-core:      '../config/paths.ts'

@pepicrft
Copy link
Contributor Author

Found the answer myself 😬

@pepicrft
Copy link
Contributor Author

@rakannimer eslint fails because the property is not being used. Do you think I should use <Helmet/> to populate the header metadata if the props is given or rather disable eslint for that line and let the users override how they want to use the prop?

@selbekk
Copy link
Contributor

selbekk commented Oct 16, 2019

@pepibumur you don't have to destructure out the doc property from props - it will still be available for when you shadow the component.

@pepicrft
Copy link
Contributor Author

@pepibumur you don't have to destructure out the doc property from props - it will still be available for when you shadow the component.

Just pushed a commit following your suggestion.

@rakannimer
Copy link
Contributor

Looks good @pepibumur thanks !

@rakannimer rakannimer merged commit 647a693 into doczjs:master Oct 17, 2019
@rakannimer
Copy link
Contributor

Published to npm as docz@2.0.0-rc.58

@pepicrft pepicrft deleted the wrapper-doc branch October 18, 2019 10:21
@pepicrft
Copy link
Contributor Author

Thanks a lot @rakannimer

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize meta description
3 participants