This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
Playground encapsulation / iframe around the playground #1304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a iFrame around every playground to solve problems like these: #1271 #1170
One example for the above mentioned issues is the component in dev-env/basic (https://github.com/doczjs/docz/tree/master/dev-env/basic) which currently inherits the font-family from the surrounding docz styles.
I still have open todos for this PR but already wanted to created it to make sure that I am on the correct way for solving these issues. :)
Drawbacks and issues
Open topics