Docz external resolve fix #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain to me how this could improve or what this changes? Because all dependencies and external are already not bundled. |
pedronauck
reviewed
Apr 24, 2019
| !id.startsWith('\0') && | ||
| !id.startsWith('.') && | ||
| !id.startsWith(process.platform === 'win32' ? process.cwd() : '/') && | ||
| !id.startsWith('@components') && |
This is an alternative (cross-platform) solution for searching external dependencies. Do you think the expression like !id.startsWith ('.') is safe? |
|
I never have any problem with this, but we can keep both I think, we don't need to remove the default external configuration and the external configuration configured inside the modules, just add this plugin in the default plugins. |
pedronauck
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #783