Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Rename feature 'certificates' #133

Closed
ThomasMinor opened this issue Jan 16, 2024 · 2 comments · Fixed by #157
Closed

FR: Rename feature 'certificates' #133

ThomasMinor opened this issue Jan 16, 2024 · 2 comments · Fixed by #157
Labels
enhancement New feature or request

Comments

@ThomasMinor
Copy link
Member

Since the feature certificates provides a means to add trusted certificate authorities to the CloudControl environment, the feature name should also reflect this purpose.

Please change the name og the feature to ca_certificates or tca.

Please add your opinions
@ThomasMinor ThomasMinor added the enhancement New feature or request label Jan 16, 2024
@ThomasMinor ThomasMinor changed the title Rename feature 'certificates' FR: Rename feature 'certificates' Jan 16, 2024
@dploeger
Copy link
Member

dploeger commented Aug 6, 2024

Hm. We need to think this through as it is a breaking change. They're still certificates, but certificates of CAs... I don't know.

@ThomasMinor
Copy link
Member Author

I suggest to add the new name and deprecate the old one.
Then we could perform the breaking change release after some more or urgent breaking changes have to be made.

dploeger added a commit that referenced this issue Aug 13, 2024
@dploeger
feat: Added CA-Certificates
bc3730b 
This is a replacement of certificates, which is deprecated with this.

Includes a feature to set a deprecation in the docs and adds a little not to prefer the FEATURES variable over the USE_ variable.

Fixes #133
@dploeger dploeger mentioned this issue Aug 13, 2024
Merged
dploeger added a commit that referenced this issue Sep 9, 2024
@dploeger
feat: Added CA-Certificates
ed6f173 
This is a replacement of certificates, which is deprecated with this.

Includes a feature to set a deprecation in the docs and adds a little not to prefer the FEATURES variable over the USE_ variable.

Fixes #133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Added CA-Certificates dodevops/cloudcontrol
2 participants
@dploeger @ThomasMinor