Merge pull request #5576 from dodona-edu/fix/unselect-only-submission

Add option to deselect only submission for evaluation
dodona-edu · Jun 4, 2024 · b9e36cb · b9e36cb
2 parents efc5e45 + 75bf474
commit b9e36cb
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/app/views/feedbacks/show.html.erb b/app/views/feedbacks/show.html.erb
@@ -36,10 +36,12 @@
                       <br/>
                     <%= t('.submission.later_attempts_html', count: @feedback.later_attempts) %>
                   <% end %>
-                  <% if @feedback.later_attempts + @feedback.previous_attempts > 0 %>
-                      <br/>
-                    <%= link_to edit_feedback_path(@feedback) do %>
+                  <br/>
+                  <%= link_to edit_feedback_path(@feedback) do %>
+                    <% if @feedback.later_attempts + @feedback.previous_attempts > 0 %>
                       <%= t("feedbacks.edit.select_another_submission") %>
+                    <% else %>
+                      <%= t("feedbacks.edit.select_no_submission") %>
                     <% end %>
                   <% end %>
                 <% elsif @feedback.total_attempts > 0 %>

diff --git a/config/locales/views/feedbacks/en.yml b/config/locales/views/feedbacks/en.yml
@@ -56,6 +56,7 @@ en:
       short_title: "Select another submission."
       select_a_submission: "Do select a submission."
       select_another_submission: "Select another submission."
+      select_no_submission: "De-select this submission."
     submissions_table:
       update-submission: "Change to this submission"
       confirm: "Are you sure? All comments on the previous submission will be deleted."

diff --git a/config/locales/views/feedbacks/nl.yml b/config/locales/views/feedbacks/nl.yml
@@ -56,6 +56,7 @@ nl:
       short_title: "Selecteer een andere ingediende oplossing."
       select_a_submission: "Selecteer toch een ingediende oplossing."
       select_another_submission: "Selecteer een andere ingediende oplossing."
+      select_no_submission: "Selectie van deze oplossing wissen."
     submissions_table:
       update-submission: "Veranderen naar deze oplossing"
       confirm: "Ben je zeker? Alle opmerkingen op de vorige oplossing zullen verwijderd worden."