-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
course_membership.js: replace with webcomponent #4083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but I have a minor UX remark. If I'm correct, you can type something that is not present in the list and add it as well, but the UI isn't super clear on that because of the double focus on "search" both in the placeholder text and the info below.
Maybe searching doesn't even have to be mentioned because it's not needed?
I agree. Would this be better, or still not clear enough? |
I agree with the info text, but would just use "Label" as placeholder text. This best matches the material design spec. |
This pull request removes course_membership.js and replaces the functionality with web components (using the already existing
d-datalist-input
), with the goal of removing jquery and converting to typescript.The view has slightly changed from this:
To this:
It is progress on #3590