Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more relevant info for teachers on course cards #4299

Merged
merged 40 commits into from
Jan 23, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jan 6, 2023

This pull request updates the course cards from #4261 , so that they display more relevant information for teachers.

The course progress is replaced by some generals statistics:

  • the number of users
  • the number of series
  • the number of exercises
  • the number of submissions

The content of the card displays the following info (In order of priority, with max three being shown):

  • the number of unanswered questions, with a link to the questions page
  • the number of pending users, with a link to review them
  • the number of submissions that still need to be reviewed, with a link to the first of those submissions
  • Up to 1 series with a recently passed deadline (within last week)
  • Up to 2 series with an upcoming deadline
  • Up to 3 series which have recently been worked on by a the most users

The series progress bars are replaced by class progress. This visualizes the amount of users that have completed a certain amount of exercises.
This class progress is now also used for series displayed in the top cards on the homepage.

The icons for open_for_institution are also removed as this is the default and does not require extra attention of the course_admin.

I have also added a progress bar on the homepage when switching between academic year. (And slightly improved it's styling because the blue on pink clashed)

Visually this looks like:

Screen Shot 2023-01-20 at 16 13 46
Screen Shot 2023-01-20 at 16 13 28

  • Tests were added

Part of #2882

@jorg-vr jorg-vr added the feature New feature or request label Jan 6, 2023
@jorg-vr jorg-vr self-assigned this Jan 6, 2023
@jorg-vr jorg-vr changed the title So more relevant info for teachers on course cards Show more relevant info for teachers on course cards Jan 6, 2023
@jorg-vr
Copy link
Contributor Author

jorg-vr commented Jan 6, 2023

Mockup 1 (WIP):

  • Added overview statistics
  • Added Action items for pending registration and open questions
    image

todo:

Add statistics that can scale from one item to full card. Either:

  • current activity
  • class progress
  • ?
    First explore statistics on course page without space limitations

Fix heights

Fix open/closed icon for registration

@jorg-vr jorg-vr temporarily deployed to naos January 11, 2023 08:29 — with GitHub Actions Inactive
@bmesuere
Copy link
Member

I would leave out the number of questions from the header (but definitely include it in the card itself if there would be any). The other numbers could be abbreviated to for example 15.5K instead of 15484.

The priority of things to show are:

  • open questions
  • pending registrations
  • series with upcoming deadline
  • series with passed deadline

For now, I would fill the rest of the slots with exercises (which is not really useful). In a later phase/PR, we could add some graphs instead of exercises.

For courses using series without deadlines, could we show something instead of the graphs? Maybe "series being worked on now"?

@jorg-vr jorg-vr temporarily deployed to naos January 17, 2023 09:57 — with GitHub Actions Inactive
Base automatically changed from feature/rethink-course-cards to develop January 18, 2023 08:48
@jorg-vr jorg-vr temporarily deployed to naos January 18, 2023 13:58 — with GitHub Actions Inactive
@jorg-vr
Copy link
Contributor Author

jorg-vr commented Jan 18, 2023

image
image
image

@jorg-vr jorg-vr marked this pull request as ready for review January 19, 2023 14:58
@jorg-vr jorg-vr requested a review from a team as a code owner January 19, 2023 14:58
@jorg-vr jorg-vr requested review from niknetniko and chvp and removed request for a team January 19, 2023 14:58
@jorg-vr jorg-vr temporarily deployed to naos January 19, 2023 16:14 — with GitHub Actions Inactive
app/models/course.rb Outdated Show resolved Hide resolved
app/views/pages/_course_card.html.erb Outdated Show resolved Hide resolved
app/views/pages/_course_card.html.erb Outdated Show resolved Hide resolved
Copy link
Member

@niknetniko niknetniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good! (I have added some small nitpicks here and there; an automated ERB formatter would be very nice)

One small side-effect I noticed though is that the home page now takes a bit longer to render. This is normal, but when using the academic year selector, there is no indication that something is actually happening. So for example, if I select another year, it feels like nothing is happening, which made me think something went wrong (although it was just loading). I think we should either add a loader or just go for a full page refresh (in which case the browser shows something is happening).

app/views/pages/_course_card.html.erb Outdated Show resolved Hide resolved
app/views/pages/_course_card.html.erb Outdated Show resolved Hide resolved
app/views/pages/_course_card.html.erb Outdated Show resolved Hide resolved
app/views/pages/_course_card.html.erb Outdated Show resolved Hide resolved
app/views/pages/_course_card.html.erb Outdated Show resolved Hide resolved
config/locales/views/pages/nl.yml Show resolved Hide resolved
config/locales/views/pages/nl.yml Show resolved Hide resolved
config/locales/views/pages/nl.yml Outdated Show resolved Hide resolved
config/locales/views/pages/en.yml Show resolved Hide resolved
config/locales/views/pages/en.yml Show resolved Hide resolved
@jorg-vr jorg-vr temporarily deployed to naos January 20, 2023 14:17 — with GitHub Actions Inactive
@jorg-vr jorg-vr merged commit fed95df into develop Jan 23, 2023
@jorg-vr jorg-vr deleted the feature/teacher-course-cards branch January 23, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants