Set version as timestamp during rails initialization #4705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
added
deploy naos
jorg-vr
added
deploy naos
jorg-vr
changed the title
jorg-vr
changed the title
jorg-vr
changed the title
jorg-vr
changed the title
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
…-edu/dodona into enhance/display-release-timestamp
bmesuere
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the fixed version number in the initializer by a frozen timestamp
This is used as the version number to be displayed in the app.
New versioning syntax used
"%y.%m.%d-%H:%M". This would match with monthly releases of the form%y.%m. Eg.23.07I have also updated the link to which the version redirects to be our github release channel.
Note: the timestamp seems to only be initialized on first page load instead of application startup. This is a noticeable difference on naos, but I don't think this will make any difference in production.
part of #4673