-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update papyros to version 2.0.0 #5204
Conversation
finally figured out the issue in the current setup. In firefox the read requests do not get intercepted by the service worker. (while write request are still intercepted as expected) The probable cause:
I confirmed this issue by using a service worker on the /assets scope, which does intercept the read requests
|
I'll publish the non beta version of 2.0.0 once this pr is approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: it did work after a hard refresh of the page I would also remove the beta label from this feature. |
The header layout is a separate bug already present in production, will fix in separate pr I am unsure if I can avoid the need for a hard refresh... |
I also needed a hard refresh on my Windows 10 machine with Google Chrome. Initially running a program got stuck after the first line of input was entered (interactive mode). |
This pull request is related to the papyros build update dodona-edu/papyros#558
Papyros moved from a prebundled file to separate files. This allows us to avoid loading a lot of dependencies twice (eg codemirror).
Required changes:
headers['Service-Worker-Allowed'] = '/'
Future work: Avoid local duplicate of serviceworker
This would greatly simplify the setup, removing extra parameters from papyros and removing extra local configuration.
I haven't done this yet as I haven't yet found how to set the header
headers['Service-Worker-Allowed'] = '/'
to a specific asset.Also, the number of changes in this papyros version was already quite large. So keeping this change for the future seemed sensible.
Bundle
Before 13.74MB
After 8.06MB
The tar with python code of 1.35MB should be added to this total
Bringing it to 9.41MB