Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra draft filter for activities #5209

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Dec 1, 2023

This pull request adds an extra filter to the activity index page and the series edit page.
This filter is only shown if the users has draft activities

image

Closes #5208

@jorg-vr jorg-vr added the enhancement A change that isn't substantial enough to be called a feature label Dec 1, 2023
@jorg-vr jorg-vr self-assigned this Dec 1, 2023
@jorg-vr jorg-vr marked this pull request as ready for review December 1, 2023 09:38
@jorg-vr jorg-vr requested a review from a team as a code owner December 1, 2023 09:38
@jorg-vr jorg-vr requested review from niknetniko and chvp and removed request for a team December 1, 2023 09:38
config/locales/views/activities/nl.yml Outdated Show resolved Hide resolved
@chvp chvp added the deploy mestra Request a deployment on mestra label Dec 1, 2023
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Dec 1, 2023
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Draft/Published" looks a little clunky to me. Maybe just "Draft" would work better? That's were I would look if I didn't want to see Draft exercises also.

jorg-vr and others added 2 commits December 1, 2023 11:12
Co-authored-by: Niko Strijbol <strijbol.niko@gmail.com>
@jorg-vr jorg-vr merged commit 72497d0 into main Dec 1, 2023
13 checks passed
@jorg-vr jorg-vr deleted the enhance/add-draft-filter branch December 1, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter on activities in concept
3 participants