Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require valid token to view series activities #5249

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Require valid token to view series activities #5249

merged 4 commits into from
Dec 20, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Dec 20, 2023 •
edited
Loading

This pull request fixes security issue described in email

  • tests are added

@jorg-vr jorg-vr added the bug Something isn't working label Dec 20, 2023
@jorg-vr jorg-vr self-assigned this Dec 20, 2023
@jorg-vr jorg-vr marked this pull request as ready for review December 20, 2023 10:00
@jorg-vr jorg-vr requested a review from a team as a code owner December 20, 2023 10:00
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team December 20, 2023 10:00
@bmesuere bmesuere requested review from chvp and removed request for bmesuere December 20, 2023 10:09
chvp
chvp approved these changes Dec 20, 2023
View reviewed changes
app/controllers/activities_controller.rb Outdated Show resolved Hide resolved
app/controllers/series_controller.rb Outdated Show resolved Hide resolved
niknetniko
niknetniko approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@niknetniko niknetniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is because pundit's policies don't like additional arguments, but this feels ugly :(

@jorg-vr jorg-vr merged commit 7b1b1bc into main Dec 20, 2023
13 checks passed
@jorg-vr jorg-vr deleted the fix/security-leak branch December 20, 2023 10:53
@BWindey BWindey mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvp chvp chvp approved these changes

@niknetniko niknetniko niknetniko approved these changes

Assignees

@jorg-vr jorg-vr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorg-vr @niknetniko @chvp