Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make iframe methods available on submissions page #5581

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Make iframe methods available on submissions page #5581

merged 2 commits into from
Jun 5, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jun 4, 2024

@jorg-vr jorg-vr added the bug Something isn't working label Jun 4, 2024
@jorg-vr jorg-vr self-assigned this Jun 4, 2024
@jorg-vr jorg-vr requested a review from a team as a code owner June 4, 2024 13:14
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team June 4, 2024 13:14
bmesuere
bmesuere approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same needs to happen on the series overview page

@jorg-vr jorg-vr merged commit 593bb9d into main Jun 5, 2024
12 of 13 checks passed
@jorg-vr jorg-vr deleted the fix/iframe-resize branch June 5, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmesuere bmesuere bmesuere approved these changes

@niknetniko niknetniko Awaiting requested review from niknetniko niknetniko was automatically assigned from dodona-edu/review

Assignees

@jorg-vr jorg-vr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorg-vr @bmesuere