Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: init network #11

Merged
merged 1 commit into from
Apr 20, 2023
Merged

fix: init network #11

merged 1 commit into from
Apr 20, 2023

Conversation

0xcb9ff9
Copy link

@0xcb9ff9 0xcb9ff9 commented Apr 20, 2023 •
edited
Loading

Description

upstream PR: #1412

Description

fields of Node.LogConfig is pointer,
when a field is not set, generate config.toml will fail for marshaling nil

Changes

Notable changes:

* add each change in a bullet point here

@0xcb9ff9 0xcb9ff9 self-assigned this Apr 20, 2023
DarianShawn
DarianShawn approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xcb9ff9 0xcb9ff9 merged commit ca9e08c into dev Apr 20, 2023
@0xcb9ff9 0xcb9ff9 deleted the upstream/fix-init-network branch April 20, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarianShawn DarianShawn DarianShawn approved these changes

@abrahamcruise321 abrahamcruise321 Awaiting requested review from abrahamcruise321 abrahamcruise321 is a code owner

Assignees

@0xcb9ff9 0xcb9ff9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xcb9ff9 @DarianShawn @NathanBSC