Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miner: fix miner competition #57

Merged
merged 10 commits into from
Nov 10, 2023
Merged

miner: fix miner competition #57

merged 10 commits into from
Nov 10, 2023

Conversation

0xcb9ff9
Copy link

@0xcb9ff9 0xcb9ff9 commented Nov 4, 2023 •
edited
Loading

Description

@0xcb9ff9 0xcb9ff9 added the bug Something isn't working label Nov 4, 2023
@0xcb9ff9 0xcb9ff9 self-assigned this Nov 4, 2023
DarianShawn
DarianShawn reviewed Nov 4, 2023
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KISS. 👍🏻 Make sense.
Though I'm object to removing all timers here:

miner/worker.go Show resolved Hide resolved
@DarianShawn DarianShawn mentioned this pull request Nov 4, 2023
Closed
DarianShawn
DarianShawn reviewed Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we almost reach the target: keep it simple.
Although we still need some optimization.

consensus/drab/hawaii.go Show resolved Hide resolved
miner/worker.go Outdated Show resolved Hide resolved
DarianShawn
DarianShawn previously approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DarianShawn
DarianShawn previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Merge it once the Devnet tests passed.

@0xcb9ff9 0xcb9ff9 changed the title miner: Fix miner competition miner: fix miner competition Nov 9, 2023
DarianShawn
DarianShawn approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM
How about the benchmark results?

@0xcb9ff9 0xcb9ff9 added this pull request to the merge queue Nov 10, 2023
Merged via the queue into dev with commit e13fda7 Nov 10, 2023
4 of 5 checks passed
@0xcb9ff9 0xcb9ff9 deleted the fix-miner-competition branch November 10, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarianShawn DarianShawn DarianShawn approved these changes

@abrahamcruise321 abrahamcruise321 Awaiting requested review from abrahamcruise321 abrahamcruise321 is a code owner

Assignees

@0xcb9ff9 0xcb9ff9

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xcb9ff9 @DarianShawn