forked from bnb-chain/bsc
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consensu/ibft: verify and finalize ibft block #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarianShawn
changed the title
consensu/ibft: verify and finalize ibft block
WIP: consensu/ibft: verify and finalize ibft block
Apr 17, 2023
DarianShawn
force-pushed
the
ibft-consensus
branch
from
April 19, 2023 02:41
40e003a
to
64ff010
Compare
### Description add `--genesis` flag, ignore read genesis block from database ### Rationale `SetEthConfig` adds process for handling Genesis JSON file ### Example ```sh ./geth --datadir=/data/dbsc --genesis=/data/genesis-dbsc-devnet.json ``` ### Changes Notable changes: * add `--genesis` flag
DarianShawn
force-pushed
the
ibft-consensus
branch
from
April 19, 2023 10:42
baa725f
to
bde270b
Compare
DarianShawn
changed the title
WIP: consensu/ibft: verify and finalize ibft block
consensu/ibft: verify and finalize ibft block
Apr 20, 2023
The block syncing and verifying logic are tested in Devnet. |
0xcb9ff9
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IBFT protocol is adopt in this PR. We provide block verification and finalizing, which are needed when downloading blocks from Dogechain V1 network.
Closes #5