Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert .tsx stories to .mdx #72

Closed
wants to merge 1 commit into from
Closed

Conversation

ChromeGG
Copy link

@ChromeGG ChromeGG commented Jul 10, 2022

Todo:

  • Fix TS support in .mdx stories,
  • Port rest of stories

@ChromeGG ChromeGG changed the title Add a example .mdx story Convert .tsx stories to .mdx Jul 10, 2022
@dohomi
Copy link
Owner

dohomi commented Jul 11, 2022

looking forward thanks for your work on this!

@TkaczykAdam
Copy link
Contributor

Dammit, I made some small research. Seems that TS is not supported in .mdx and storybook:
microsoft/TypeScript#36440

Copy link

@netknight netknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any updates?

@dohomi
Copy link
Owner

dohomi commented Mar 13, 2023

@netknight I haven't digged further into this PR as .tsx was working fine for now. if you have experience in it please go ahead I am happy to review

@dohomi
Copy link
Owner

dohomi commented May 15, 2023

I migrated to vite and storybook v7. will close this PR for now as it is definitely outdated.

@dohomi dohomi closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants