Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #528

Merged
merged 3 commits into from
Jan 13, 2024
Merged

Develop #528

merged 3 commits into from
Jan 13, 2024

Conversation

dohooo
Copy link
Owner

@dohooo dohooo commented Jan 13, 2024

No description provided.

The onScrollBegin event is triggered only when a finger touches down, which isn't consistent with
the onScrollEnd events. The correct approach would be to use the onScrollStart callback, ensuring
that both callbacks are invoked at the start and end of a scroll respectively.

BREAKING CHANGE: The onScrollBegin property has been deprecated. Please use onScrollStart as its
replacement.

fix #506
Copy link

changeset-bot bot commented Jan 13, 2024

🦋 Changeset detected

Latest commit: b654f43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-native-reanimated-carousel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 13, 2024
Copy link

vercel bot commented Jan 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-reanimated-carousel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2024 11:45pm

@dohooo dohooo merged commit 764f286 into main Jan 13, 2024
2 checks passed
@dohooo dohooo deleted the develop branch January 13, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant