Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: onGestureEnd -> endWithSpring uses outdated data via useSharedValue #600

Merged
merged 3 commits into from
May 6, 2024
Merged

fix: onGestureEnd -> endWithSpring uses outdated data via useSharedValue #600

merged 3 commits into from
May 6, 2024

Conversation

dohooo
Copy link
Owner

@dohooo dohooo commented May 6, 2024

Relates to #574

nmassey and others added 3 commits March 22, 2024 23:24
@nmassey
fix: onGestureEnd -> endWithSpring uses outdated data via useSharedValue
86da6ac
@dohooo
Merge pull request #574 from nmassey/fix-useSharedValue-async-updates
9f14e92 
fix: `onGestureEnd` -> `endWithSpring` uses outdated data via `useSharedValue`
@dohooo
fix: fixed an issue, which causing incorrect carousel behavior on dir…
d9557b2 
…ection reversal

endWithSpring used outdated data from useSharedValue after onGestureEnd, causing incorrect carousel
behavior on direction reversal.

Closes #535, Closes #568, Closes #579
@dohooo dohooo added the bug Something isn't working label May 6, 2024
@dohooo dohooo self-assigned this May 6, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 6, 2024

🦋 Changeset detected

Latest commit: d9557b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-native-reanimated-carousel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 6, 2024
@vercel Vercel
Copy link

vercel bot commented May 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-reanimated-carousel ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 9:56am

@dohooo dohooo merged commit dd43da8 into main May 6, 2024
2 checks passed
@dohooo dohooo deleted the dev branch May 6, 2024 10:08
@github-actions github-actions bot mentioned this pull request May 6, 2024
Merged
@BrodaNoel
Copy link
Contributor

You can't imagine how happy I am of seeing these PRs getting merged! Thanks for that! This is one of the bugs that was blocking my release.

I'm gonna try it today and give some feedback.
Thanks again!

@dohooo
Copy link
Owner Author

dohooo commented May 6, 2024

You can't imagine how happy I am of seeing these PRs getting merged! Thanks for that! This is one of the bugs that was blocking my release.

I'm gonna try it today and give some feedback. Thanks again!

Sorry for keeping you waiting for so long.

@BrodaNoel
Copy link
Contributor

Naaaa, no problem. Everything can wait in this life

@dohooo dohooo restored the dev branch May 6, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dohooo dohooo

Labels
bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dohooo @BrodaNoel @nmassey