Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript error where MeasuredDimension can be null #629

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

nickoelsner
Copy link
Contributor

Bug:

we updated react-native-reanimated-carousel to version v4.0.0-alpha.12 in our project and ran into this type error in ScrollViewGesture.tsx:

image

Fix:

added a null check to the MeasuredDimension, with a default of 0

Copy link

changeset-bot bot commented Jun 14, 2024

⚠️ No Changeset found

Latest commit: 80ec737

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 14, 2024
@dohooo dohooo changed the base branch from main to dev September 8, 2024 14:44
@dohooo dohooo merged commit 0cd751f into dohooo:dev Sep 8, 2024
1 check failed
@dohooo dohooo mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants