Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix carousel sizing #647

Closed
wants to merge 1 commit into from
Closed

Conversation

itsramiel
Copy link

Closes #646

In react-native-gesture-handler v2.16.0, a style of {flex: 1} was added to GestureHandlerRootView in this pr.

This styling leads to the issues mentioned in #646

In order to fix the issue, the width and height are set on the GestureHandlerRootView and the container has a flex: 1 to fill in the GestureHandlerRootView

Copy link

changeset-bot bot commented Jul 19, 2024

⚠️ No Changeset found

Latest commit: 1e505cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-reanimated-carousel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 5:15pm

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 19, 2024
@itsramiel itsramiel closed this by deleting the head repository Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel component does not size itself correctly
1 participant