[dxgi] Only log QueryInterface errors once

doitsujin · Mar 1, 2023 · 55e7cb1 · 55e7cb1
1 parent 4c78964
commit 55e7cb1
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 12 deletions.
diff --git a/src/dxgi/dxgi_adapter.cpp b/src/dxgi/dxgi_adapter.cpp
@@ -103,8 +103,11 @@ namespace dxvk {
       return S_OK;
     }
 
-    Logger::warn("DxgiAdapter::QueryInterface: Unknown interface query");
-    Logger::warn(str::format(riid));
+    if (logQueryInterfaceError(__uuidof(IDXGIAdapter), riid)) {
+      Logger::warn("DxgiAdapter::QueryInterface: Unknown interface query");
+      Logger::warn(str::format(riid));
+    }
+
     return E_NOINTERFACE;
   }
 

diff --git a/src/dxgi/dxgi_factory.cpp b/src/dxgi/dxgi_factory.cpp
@@ -93,8 +93,11 @@ namespace dxvk {
       return S_OK;
     }
 
-    Logger::warn("DxgiFactory::QueryInterface: Unknown interface query");
-    Logger::warn(str::format(riid));
+    if (logQueryInterfaceError(__uuidof(IDXGIFactory), riid)) {
+      Logger::warn("DxgiFactory::QueryInterface: Unknown interface query");
+      Logger::warn(str::format(riid));
+    }
+
     return E_NOINTERFACE;
   }
 

diff --git a/src/dxgi/dxgi_output.cpp b/src/dxgi/dxgi_output.cpp
@@ -110,8 +110,11 @@ namespace dxvk {
       return S_OK;
     }
 
-    Logger::warn("DxgiOutput::QueryInterface: Unknown interface query");
-    Logger::warn(str::format(riid));
+    if (logQueryInterfaceError(__uuidof(IDXGIOutput), riid)) {
+      Logger::warn("DxgiOutput::QueryInterface: Unknown interface query");
+      Logger::warn(str::format(riid));
+    }
+
     return E_NOINTERFACE;
   }
 

diff --git a/src/dxgi/dxgi_surface.cpp b/src/dxgi/dxgi_surface.cpp
@@ -29,8 +29,11 @@ namespace dxvk {
       return S_OK;
     }
 
-    Logger::warn("DxgiSurfaceFactory::QueryInterface: Unknown interface query");
-    Logger::warn(str::format(riid));
+    if (logQueryInterfaceError(__uuidof(IDXGIVkSurfaceFactory), riid)) {
+      Logger::warn("DxgiSurfaceFactory::QueryInterface: Unknown interface query");
+      Logger::warn(str::format(riid));
+    }
+
     return E_NOINTERFACE;
   }
 

diff --git a/src/dxgi/dxgi_swapchain.cpp b/src/dxgi/dxgi_swapchain.cpp
@@ -65,8 +65,11 @@ namespace dxvk {
       return S_OK;
     }
 
-    Logger::warn("DxgiSwapChain::QueryInterface: Unknown interface query");
-    Logger::warn(str::format(riid));
+    if (logQueryInterfaceError(__uuidof(IDXGISwapChain), riid)) {
+      Logger::warn("DxgiSwapChain::QueryInterface: Unknown interface query");
+      Logger::warn(str::format(riid));
+    }
+
     return E_NOINTERFACE;
   }
 

diff --git a/src/dxgi/dxgi_swapchain_dispatcher.h b/src/dxgi/dxgi_swapchain_dispatcher.h
@@ -61,8 +61,11 @@ namespace dxvk {
         return S_OK;
       }
 
-      Logger::warn("DxgiSwapChainDispatcher::QueryInterface: Unknown interface query");
-      Logger::warn(str::format(riid));
+      if (logQueryInterfaceError(__uuidof(IDXGISwapChain), riid)) {
+        Logger::warn("DxgiSwapChainDispatcher::QueryInterface: Unknown interface query");
+        Logger::warn(str::format(riid));
+      }
+
       return m_dispatch->QueryInterface(riid, ppvObject);
     }