Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[util] Add workarounds for Garden Warfare 2 #2700

Merged
merged 1 commit into from
Jul 2, 2022
Merged

[util] Add workarounds for Garden Warfare 2 #2700

merged 1 commit into from
Jul 2, 2022

Conversation

Blisto91
Copy link
Contributor

@Blisto91 Blisto91 commented Jun 28, 2022

Game won't launch with amd vendorId but works with 10de. Everyone on ProtonDB sets it to 1c06 instead which also works, but i couldn't find whose vendorId that was so just went with 10de. Didn't find it to cause any issues from some short testing.

@Blisto91
Copy link
Contributor Author

DadSchoorse correctly pointed out disabling nvapiHack was redundant so I've removed that part.

@Blisto91
Copy link
Contributor Author

Blisto91 commented Jun 29, 2022

Reworded the comment a bit.

@gofman Figured that the issue is when the game sees a amd gpu it will try to use atiadlxx which it will fail to do. With proton using WINEDLLOVERRIDES="atiadlxx=b" %command% will make it work too. That workaround has been added to experimental bleeding edge now as that was deemed a better solution.
Overwriting the vendorId to 10de will probably make the above override useless. But without 10de the game doesn't launch out of the box on wine versions where the atiadlxx work/override isn't available.

A middle ground would be to allow these vendorId's to also be set through a env var. Then proton could rid this built in config, without the user having to make a dxvk.conf, and make their own workaround work out of the box. But it would still leave this built in workaround for users where that isn't a option.

@Blisto91 Blisto91 requested a review from doitsujin June 29, 2022 18:25
@pchome
Copy link
Contributor

pchome commented Jun 30, 2022

@Blisto91

Then proton could rid this built in config, without the user having to make a dxvk.conf,

Or Proton could make their own dxvk.conf on the fly, like it's done in e.g. protonfixes (provides additional per-game configuration on top of Proton, also AFAIK it's integrated in GE builds). If they don't want (or can't have, idk) the whole thing in Proton, they have my permission to freely use my commits from that project (subj).

@Blisto91
Copy link
Contributor Author

@pchome Ye that is also possible ofc. I did have it on my mind, but didn't know how practical it was.
But if that method is already in use other places and works fine that's cool 🙂

@pchome
Copy link
Contributor

pchome commented Jun 30, 2022

BTW for single overrides (no separate config file needed) protonfixes supports "aliases" to its builtin functions in command line. So on Proton side such override could be something like
WINEDLLOVERRIDES="atiadlxx=b" -pf_dxvk_set=dxgi.customVendorId=-1 %command%

@doitsujin doitsujin merged commit 98dcd72 into doitsujin:master Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants