Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for generating version.h inside container jobs due to the new git setting
safe.directory
Just in same way as it's already fixed for other projects on repository side:
HansKristian-Work/vkd3d-proton@0c4df9b
jp7677/dxvk-nvapi@3052a78
There is a problem with
artifacts.yml
:https://github.com/doitsujin/dxvk/runs/7400427307?check_suite_focus=true#step:5:86
This change will return and again allow to see inside the game in
DXVK_HUD
(and logs) the version generated bygit describe
instead of fallback to the regular release tag (e.g.v1.10.1-322-g330ff8fa
instead ofv1.10.1
).As I understand it, the problem appeared due to git security update https://github.blog/2022-04-12-git-security-vulnerability-announced/.
The default behavior of the new
safe.directory
option broke https://github.com/actions/checkout and this has been fixed in recent versions of actions/checkout#762.But it doesn't seem to affect containers yet, and the behavior of git
safe.directory
remains the same in them.(Fortunately, this does not affect local builds of dxvk in any way.)
I've tested the latest versions but haven't found any other working way yet than using the workaround described here: actions/checkout#766 (comment)
UPD. @Joshua-Ashton I checked. This change inside docker helps as alternative fix on container side: Iglu47/arch-mingw-github-action@cd665ba