[d3d9] Only set initial NeedsUpload for D3DPOOL_MANAGED textures #3664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K0bin
force-pushed
the
bind-scratch-fix
branch
from
84fdc5e
to
f2b8e57
Compare
K0bin
changed the title
|
Do we need to do this for SYSTEMMEM what is the behaviour there? |
K0bin
force-pushed
the
bind-scratch-fix
branch
from
f2b8e57
to
244e5e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO this is the better fix for #3662.
Right now, binding a system mem / scratch texture will make us call FlushImage for that texture which crashes because there is no image. On top of that, we may end up uploading recently created D3DPOOL_DEFAULT textures which means we basically clear it again.