[d3d9] Handle remaining edge cases of Discard & Lockable #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with 9 random d3d9 games of varied engines so far, not seen any issues. Tested on Nvidia. |
PatrickvL
reviewed
Aug 2, 2024
Surfaces cannot be bound as textures.
K0bin
force-pushed
the
discard-lockable-cleanup
branch
from
5b87402 to
42b43b0
Compare
|
Looks fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of edge cases we weren't handling properly.
This is gonna need some testing.
In theory we could also use VK_STORE_OP_DONT_CARE for discardable depth stencil surfaces but I don't think that's worth the additional complexity. Tracking the load op is already a bit of a mess. Games don't really use discardable depth stencil surfaces all that much and it would only help tilers anyway as far as I know.