Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d3d9] ResolveZ: Only copy aspects that both images support #4292

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

K0bin
Copy link
Collaborator

@K0bin K0bin commented Sep 24, 2024

Fixes #4291

The game uses the RESZ hack to copy from a D3DFMT_D24S8 texture to one with format D3DFMT_DF24.

We don't want to blit stencil when the D3D9 format doesn't have
stencil.
@K0bin K0bin added the d3d9 label Sep 24, 2024
Copy link
Owner

@doitsujin doitsujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question, lgtm otherwise

src/d3d9/d3d9_device.cpp Show resolved Hide resolved
@misyltoad misyltoad merged commit f5ca3cf into doitsujin:master Sep 24, 2024
4 checks passed
@K0bin K0bin deleted the depth-blit branch September 24, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[d3d9] The First Templar has lighting issues, not present with wined3d
3 participants