[d3d8] Stub DebugSetMute to fix C&C:Generals performance #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitsujin
reviewed
Oct 10, 2024
|
In case the game will break again in the future, it may be worth pointing out that the reason this patch works is actually that inserting this function made the code/data alignment properties fall more in line to what the game is expecting. |
|
no it doesn't |
|
Well to my understanding it does, as running the game through a simple wrapper on the pre-patch dxvk was solving this issue too, where DebugSetMute() was not defined. |
|
because that wrapper stubs the function. |
|
No, it was my own experimental wrapper only defining Direct3DCreate8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has to be like the dumbest thing ever, but C&C: Generals is spamming calls to DebugSetMute() every frame whenever the slowdowns occur. Stubbing it makes it not choke. Fixes #4112.