[d3d9] Don't clear mipGenBit if texture is bound as attachment #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4344
The map binds a
AUTOGENMIPMAPtexture as RT, callsGenerateMipSubLevelswhich clears the dirty bits, renders to the texture and then callsGenerateMipSubLevelsagain which just exits out early because of the cleared dirty bits.The contents of mip 0 have changed however due to some drawing. I don't want to mark the texture mip gen bits as dirty on every single draw, so instead I decided to just don't clear them if the texture is currently bound as RT. They will get cleared once the game changes RT and then generates the mip levels.