Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #4451

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update README.md #4451

wants to merge 6 commits into from

Conversation

m1m1k4tz
Copy link

Programmatically set registry keys

Programmatically set registry keys
Update directions
Add uninstall instructions
@Blisto91
Copy link
Contributor

I think this might make things too verbose. At least the uninstall section is quite unpleasant with all the extra lines imo.
You'd also need to update the case of a 32bit prefix.

Small fixes, finish up the 32 bit stuff
@m1m1k4tz
Copy link
Author

Okay, I've added the 32 bit section and also some other fixes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Reduce the lines of code in the uninstall section
@LucasSnatiago
Copy link

@Blisto91 is it ok to use curly braces in scripts like this? I'm new to programming and shell script. I don't know if it works across all the shells available for linux.

@Blisto91
Copy link
Contributor

Sorry i haven't really dabbled either.

@m1m1k4tz
Copy link
Author

@Blisto91 is it ok to use curly braces in scripts like this? I'm new to programming and shell script. I don't know if it works across all the shells available for linux.

https://www.gnu.org/software/bash/manual/html_node/Brace-Expansion.html

I think most shells would probably implement this and it should work unless theres a specific bug in the shell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants